virtiofsd inconsistent forget behavior

[Fyodor Bocharov]

Hi.

 

We found out that forget datapath in virtiofsd's fuse impl calls `fuse_reply_err` in case of invalid request https://gitlab.com/qemu-project/qemu/-/blob/master/tools/virtiofsd/fuse_lowlevel.c#L724 but if there is no user defined `forget` it calls `fuse_reply_none` (unlike other functions which call `fuse_reply_err(ENOSYS)`).

Could you please explain why is it so? Shouldn't it call `fuse_reply_none` no matter what error is?

 

Thanks,

Fyodor