Re: [PATCH v3 00/10] add generic vDPA device support

[Stefano Garzarella]

On Sat, Mar 19, 2022 at 03:20:02PM +0800, Longpeng(Mike) wrote:
> From: Longpeng <longpeng2@huawei.com>
>
> Hi guys,
>
> With the generic vDPA device, QEMU won't need to touch the device
> types any more, such like vfio.
>
> We can use the generic vDPA device as follow:
>  -device vhost-vdpa-device-pci,vdpa-dev=/dev/vhost-vdpa-X
>
> I've done some simple tests on Huawei's offloading card (net, 0.95)
> and vdpa_sim_blk (1.0);

The whole seems almost okay, I left you some comments, but for the next 
version maybe it's better to reorganize the series differently.

Instead of adding vdpa-dev and vdpa-dev-pci incrementally, with stub 
functions and untestable parts, I would make a patch that adds vdpa-dev 
in full and then one that adds vdpa-dev-pci.
The first 2 patches on the other hand are okay, maybe patch 2 won't be 
needed since I think we will sync the headers after the 7.0 release, but 
is better to keep it for now to simplify the review.

Thanks,
Stefano