Re: [RFC PATCH v7 13/29] target/loongarch: Add gdb support.

[Richard Henderson]

On 3/28/22 06:57, Xiaojuan Yang wrote:
> +int loongarch_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
> +{
> +    LoongArchCPU *cpu = LOONGARCH_CPU(cs);
> +    CPULoongArchState *env = &cpu->env;
> +    target_ulong tmp = ldtul_p(mem_buf);
> +
> +    if (0 <= n && n < 32) {
> +        return env->gpr[n] = tmp, sizeof(target_ulong);

Ew.  Do not use the comma operator with return.
Split these into two statements, all through this file.


r~