Re: [PATCH 10/15] tests/tcg: remove CONFIG_USER_ONLY from config-target.mak

[Philippe Mathieu-Daudé]

On 28/3/22 16:02, Paolo Bonzini wrote:
> Just check the target name instead.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   tests/tcg/Makefile.target |  8 ++++----
>   tests/tcg/configure.sh    | 12 +++---------
>   2 files changed, 7 insertions(+), 13 deletions(-)

> diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
> index b09956c14d..a17db8ce64 100755
> --- a/tests/tcg/configure.sh
> +++ b/tests/tcg/configure.sh
> @@ -225,18 +225,12 @@ for target in $target_list; do
>     echo "TARGET_NAME=$arch" >> $config_target_mak
>     echo "target=$target" >> $config_target_mak
>     case $target in
> -    *-linux-user)
> -      echo "CONFIG_USER_ONLY=y" >> $config_target_mak
> -      echo "QEMU=$PWD/qemu-$arch" >> $config_target_mak
> -      ;;
> -    *-bsd-user)
> -      echo "CONFIG_USER_ONLY=y" >> $config_target_mak
> -      echo "QEMU=$PWD/qemu-$arch" >> $config_target_mak
> -      ;;
>       *-softmmu)
> -      echo "CONFIG_SOFTMMU=y" >> $config_target_mak
>         echo "QEMU=$PWD/qemu-system-$arch" >> $config_target_mak
>         ;;
> +    *)

Can we restrict to:

       *-user)

just in case?

> +      echo "QEMU=$PWD/qemu-$arch" >> $config_target_mak
> +      ;;
>     esac

With '*-user':
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>