Re: [RFC PATCH v7 19/29] hw/intc: Add LoongArch extioi interrupt controller(EIOINTC)

[Richard Henderson]

On 3/28/22 06:57, Xiaojuan Yang wrote:
> +static uint64_t extioi_ipmap_enable_read(void *opaque, hwaddr addr,
> +                                         unsigned size)
> +{
> +    LoongArchExtIOI *s = LOONGARCH_EXTIOI(opaque);
> +    uint8_t ret;
> +
> +    switch (addr) {
> +    case EXTIOI_IPMAP_START ... EXTIOI_IPMAP_END - 1:
> +        ret = s->ipmap[addr];
> +        break;
> +    case EXTIOI_ENABLE_START ... EXTIOI_ENABLE_END - 1:
> +        addr -= EXTIOI_ENABLE_START;
> +        ret = s->enable[addr];
> +        break;
> +    default:
> +        break;
> +    }
> +
> +    trace_loongarch_extioi_ipmap_enable_read((uint8_t)addr, ret);
> +    return ret;
> +}

There are at least 4 instances of uninitialized use of 'ret' in this file, and this is 
one.  Are you compiling with --disable-werror?  You must not do that.


r~