Re: [PATCH v3 05/10] vdpa-dev: implement the realize interface

[Stefano Garzarella]

On Tue, Mar 29, 2022 at 7:16 AM Longpeng (Mike, Cloud Infrastructure
Service Product Dept.) <longpeng2@huawei.com> wrote:
> > On Sat, Mar 19, 2022 at 03:20:07PM +0800, Longpeng(Mike) wrote:
> > >From: Longpeng <longpeng2@huawei.com>
> > >
>
> [snap]
>
> > > static void vhost_vdpa_device_unrealize(DeviceState *dev)
> > >@@ -66,6 +197,7 @@ static void vhost_vdpa_device_set_status(VirtIODevice 
> > >*vdev,
> > uint8_t status)
> > > static Property vhost_vdpa_device_properties[] = {
> > >     DEFINE_PROP_STRING("vdpa-dev", VhostVdpaDevice, vdpa_dev),
> > >     DEFINE_PROP_INT32("vdpa-dev-fd", VhostVdpaDevice, vdpa_dev_fd, -1),
> >
> > Other vhost devices use the `vhostfd` property, maybe we should use the
> > same name.
> >
> > If we go for this change, then maybe we also need to change `vdpa-dev`
> > to `vhostpath` or something like that
> >
>
> Make sense.
>
> I prefer to use 'vhostdev' for the file path, just like the usage in Netdev:
>   -netdev type=vhost-vdpa,vhostdev=/dev/vhost-vdpa-0,id=vhostvdpa1
>

Yep, I agree with 'vhostdev'.

Thanks,
Stefano