[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event |
|
Date: |
Tue, 29 Mar 2022 17:40:42 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @timestamp. Provide it.
>
> Example output is not properly formatted. Fixing it by:
> - Adding '<-' to signalize it is receiving the data;
> - Breaking lines similar to the other examples.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/migration.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 18e2610e88..092a63354b 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1736,7 +1736,9 @@
> # Since: 4.2
> #
> # Example:
> -# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} }
> +# <- { "event": "UNPLUG_PRIMARY",
> +# "data": { "device-id": "hostdev0" },
> +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> #
> ##
> { 'event': 'UNPLUG_PRIMARY',
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v3 00/14] Fix some qapi examples and a TODO section, Victor Toso, 2022/03/28
- [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event, Victor Toso, 2022/03/28
- [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event, Victor Toso, 2022/03/28
- [PATCH v3 01/14] qapi: BlockExportRemoveMode: move comments to TODO, Victor Toso, 2022/03/28
- [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event, Victor Toso, 2022/03/28
- [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event, Victor Toso, 2022/03/28
- [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event, Victor Toso, 2022/03/28
- Re: [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event,
Markus Armbruster <=
- [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event, Victor Toso, 2022/03/28
- [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event, Victor Toso, 2022/03/28
- [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events, Victor Toso, 2022/03/28
- [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp, Victor Toso, 2022/03/28
- [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE, Victor Toso, 2022/03/28