[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events |
|
Date: |
Tue, 29 Mar 2022 17:45:56 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @reason. Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/run-state.json | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 43d66d700f..1b9f64c9cd 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json
> @@ -150,7 +150,8 @@
> #
> # Example:
> #
> -# <- { "event": "SHUTDOWN", "data": { "guest": true },
> +# <- { "event": "SHUTDOWN",
> +# "data": { "guest": true, "reason": "guest-shutdown" },
> # "timestamp": { "seconds": 1267040730, "microseconds": 682951 } }
> #
> ##
> @@ -188,7 +189,8 @@
> #
> # Example:
> #
> -# <- { "event": "RESET", "data": { "guest": false },
> +# <- { "event": "RESET",
> +# "data": { "guest": false, "reason": "guest-reset" },
> # "timestamp": { "seconds": 1267041653, "microseconds": 9518 } }
> #
> ##
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- Re: [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event, (continued)
- [PATCH v3 01/14] qapi: BlockExportRemoveMode: move comments to TODO, Victor Toso, 2022/03/28
- [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event, Victor Toso, 2022/03/28
- [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event, Victor Toso, 2022/03/28
- [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event, Victor Toso, 2022/03/28
- [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event, Victor Toso, 2022/03/28
- [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event, Victor Toso, 2022/03/28
- [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events, Victor Toso, 2022/03/28
- Re: [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events,
Markus Armbruster <=
- [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp, Victor Toso, 2022/03/28
- [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE, Victor Toso, 2022/03/28
- [PATCH v3 12/14] qapi: ui examples: add missing @websocket member, Victor Toso, 2022/03/28
- [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event, Victor Toso, 2022/03/28
- [PATCH v3 14/14] qapi: fix example of dump-guest-memory, Victor Toso, 2022/03/28