Re: [RFC PATCH v7 10/29] target/loongarch: Add other core instructions support

[yangxiaojuan]

On 2022/3/29 上午4:16, Richard Henderson wrote:
> On 3/28/22 06:57, Xiaojuan Yang wrote:
> > +void helper_idle(CPULoongArchState *env)
> > +{
> > +    CPUState *cs = env_cpu(env);
> > +
> > +    cs->halted = 1;
> > +    cpu_reset_interrupt(cs, CPU_INTERRUPT_WAKE);
> > +    do_raise_exception(env, EXCP_HLT, 0);
> > +}
>
> Why are you messing with CPU_INTERRUPT_WAKE?
> You only ever reset it, and never set it.
Useless code,  we just need set cs->halted.

Thanks
Xiaojuan
> r~