Re: [PATCH v2 39/50] lasi: use constants for device register offsets

[Richard Henderson]

On 5/4/22 04:25, Mark Cave-Ayland wrote:
> Instead of generating the offset based upon the physical address of the
> register, add constants for each of the device registers to lasi.h and
> update lasi.c to use them.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Acked-by: Helge Deller <deller@gmx.de>
> ---
>   hw/hppa/lasi.c | 28 ++++++++++++++--------------
>   hw/hppa/lasi.h |  5 +++++
>   2 files changed, 19 insertions(+), 14 deletions(-)

Worth removing the final usages, and the old definitions in hppa_machine.h?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~