qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/6] bsd-user/freebsd/os-syscall.c: Tracing and error boilerp


From: Warner Losh
Subject: Re: [PATCH 3/6] bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate
Date: Tue, 7 Jun 2022 14:56:27 -0700



On Tue, Jun 7, 2022 at 2:34 PM Richard Henderson <richard.henderson@linaro.org> wrote:
On 6/7/22 13:14, Warner Losh wrote:
> +static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
> +                                abi_long arg2, abi_long arg3, abi_long arg4,
> +                                abi_long arg5, abi_long arg6, abi_long arg7,
> +                                abi_long arg8)
> +{
> +    abi_long ret;
> +
> +    switch (num) {
> +    default:
> +        gemu_log("qemu: unsupported syscall: %d\n", num);

qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);

Agreed.
 

> +#ifdef DEBUG
> +    gemu_log("freebsd syscall %d\n", num);
> +#endif

Drop this.  It's redundant with strace.

Yea, it was a quick hack in the past that the wrapper function highlighted nicely..
 
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks!

Warner

reply via email to

[Prev in Thread] Current Thread [Next in Thread]