[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 08/11] target/mips: Use error_report for UHI_assert
From: |
Richard Henderson |
Subject: |
[PATCH v4 08/11] target/mips: Use error_report for UHI_assert |
Date: |
Tue, 7 Jun 2022 22:19:42 -0700 |
Always log the assert locally. Do not report_fault, but
instead include the fact of the fault in the assertion.
Don't bother freeing allocated strings before the abort().
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/mips/tcg/sysemu/mips-semi.c | 39 ++++++++++++++----------------
1 file changed, 18 insertions(+), 21 deletions(-)
diff --git a/target/mips/tcg/sysemu/mips-semi.c
b/target/mips/tcg/sysemu/mips-semi.c
index ad11a46820..ae4b8849b1 100644
--- a/target/mips/tcg/sysemu/mips-semi.c
+++ b/target/mips/tcg/sysemu/mips-semi.c
@@ -221,18 +221,6 @@ static int copy_argn_to_target(CPUMIPSState *env, int
arg_num,
} \
} while (0)
-#define GET_TARGET_STRINGS_2(p, addr, p2, addr2) \
- do { \
- p = lock_user_string(addr); \
- if (!p) { \
- report_fault(env); \
- } \
- p2 = lock_user_string(addr2); \
- if (!p2) { \
- report_fault(env); \
- } \
- } while (0)
-
#define FREE_TARGET_STRING(p, gpr) \
do { \
unlock_user(p, gpr, 0); \
@@ -243,7 +231,7 @@ void mips_semihosting(CPUMIPSState *env)
CPUState *cs = env_cpu(env);
target_ulong *gpr = env->active_tc.gpr;
const UHIOp op = gpr[25];
- char *p, *p2;
+ char *p;
switch (op) {
case UHI_exit:
@@ -355,14 +343,23 @@ void mips_semihosting(CPUMIPSState *env)
break;
case UHI_assert:
- GET_TARGET_STRINGS_2(p, gpr[4], p2, gpr[5]);
- printf("assertion '");
- printf("\"%s\"", p);
- printf("': file \"%s\", line %d\n", p2, (int)gpr[6]);
- FREE_TARGET_STRING(p2, gpr[5]);
- FREE_TARGET_STRING(p, gpr[4]);
- abort();
- break;
+ {
+ const char *msg, *file;
+
+ msg = lock_user_string(gpr[4]);
+ if (!msg) {
+ msg = "<EFAULT>";
+ }
+ file = lock_user_string(gpr[5]);
+ if (!file) {
+ file = "<EFAULT>";
+ }
+
+ error_report("UHI assertion \"%s\": file \"%s\", line %d",
+ msg, file, (int)gpr[6]);
+ abort();
+ }
+
default:
error_report("Unknown UHI operation %d", op);
abort();
--
2.34.1
- [PATCH v4 03/11] target/mips: Create report_fault for semihosting, (continued)
- [PATCH v4 03/11] target/mips: Create report_fault for semihosting, Richard Henderson, 2022/06/08
- [PATCH v4 06/11] target/mips: Use semihosting/syscalls.h, Richard Henderson, 2022/06/08
- [PATCH v4 04/11] target/mips: Drop link syscall from semihosting, Richard Henderson, 2022/06/08
- [PATCH v4 09/11] semihosting: Remove qemu_semihosting_log_out, Richard Henderson, 2022/06/08
- [PATCH v4 07/11] target/mips: Avoid qemu_semihosting_log_out for UHI_plog, Richard Henderson, 2022/06/08
- [PATCH v4 05/11] target/mips: Drop pread and pwrite syscalls from semihosting, Richard Henderson, 2022/06/08
- [PATCH v4 08/11] target/mips: Use error_report for UHI_assert,
Richard Henderson <=
- [PATCH v4 10/11] target/mips: Simplify UHI_argnlen and UHI_argn, Richard Henderson, 2022/06/08
- [PATCH v4 11/11] target/mips: Remove GET_TARGET_STRING and FREE_TARGET_STRING, Richard Henderson, 2022/06/08