|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v5 06/10] hmp: add basic "info stats" implementation |
Date: | Wed, 8 Jun 2022 16:27:36 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
On 6/7/22 20:35, Dr. David Alan Gilbert wrote:
+ monitor_printf(mon, "%s", iec_binary_prefix(value->exponent));OK that's better; but it's a shame the limits don't come from something shared; iec_binary_prefix goes upto 60 and si_prefix goes way below -9 Reviewed-by: Dr. David Alan Gilbert<dgilbert@redhat.com>
I can remove the limits altogether, and consider it a bug of the provider if they're not respected, but it's a bit ugly to have an assertion failure in that case.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |