[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gitlab: convert Cirrus jobs to .base_job_template
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: gitlab: convert Cirrus jobs to .base_job_template |
|
Date: |
Wed, 8 Jun 2022 17:07:33 +0100 |
|
User-agent: |
Mutt/2.2.1 (2022-02-19) |
On Wed, Jun 08, 2022 at 08:48:48AM -0700, Richard Henderson wrote:
> Commit 00125414ba1 is not working as intended. E.g.
>
> https://gitlab.com/rth7680/qemu/-/jobs/2558862885
>
> where I have neither CIRRUS_GITHUB_REPO nor CIRRUS_API_TOKEN set, but the
> job tries to run anyway. Then fails, predictably, with "token not defined".
Opps, GitLab variable comparisons aren't shell-like where an unset
variable compares equal to empty string.
I just sent a fix & CC'd you
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|