[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] configure: update list of preserved environment variables
|
From: |
Matheus Kowalczuk Ferst |
|
Subject: |
Re: [PATCH] configure: update list of preserved environment variables |
|
Date: |
Wed, 8 Jun 2022 16:29:24 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 07/06/2022 07:49, Paolo Bonzini wrote:
> INSTALL and LIBTOOL are not used anymore, but OBJCFLAGS is new and
> was not listed.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> configure | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index f35847c3cd..ce81419629 100755
> --- a/configure
> +++ b/configure
> @@ -2737,13 +2737,12 @@ preserve_env CC
> preserve_env CFLAGS
> preserve_env CXX
> preserve_env CXXFLAGS
> -preserve_env INSTALL
> preserve_env LD
> preserve_env LDFLAGS
> preserve_env LD_LIBRARY_PATH
> -preserve_env LIBTOOL
> preserve_env MAKE
> preserve_env NM
> +preserve_env OBJCFLAGS
> preserve_env OBJCOPY
> preserve_env PATH
> preserve_env PKG_CONFIG
> --
> 2.36.1
>
>
Reviewed-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
I wonder if there are more unused variables, e.g., WINDRES and
SDL2_CONFIG have some references but it seems that they are only saved
and never used.
--
Matheus K. Ferst
Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/>
Analista de Software
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>