qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 10/53] semihosting: Adjust error checking in common_semi_c


From: Alex Bennée
Subject: Re: [PATCH v4 10/53] semihosting: Adjust error checking in common_semi_cb
Date: Wed, 08 Jun 2022 18:19:18 +0100
User-agent: mu4e 1.7.26; emacs 28.1.50

Richard Henderson <richard.henderson@linaro.org> writes:

> The err parameter is non-zero if and only if an error occured.
> Use this instead of ret == -1 for determining if we need to
> update the saved errno.
>
> This fixes the errno setting of SYS_ISTTY, which returns 0 on
> error, not -1.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]