[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo |
Date: |
Thu, 9 Jun 2022 15:34:11 +0200 |
Hi,
> > > > (1) add refresh_rate
> > > > (2) update users one by one
> > > > (3) finally drop update_interval when no user is left.
> > > >
> > > > thanks,
> > > > Gerd
> > > >
> > >
> > > I think 1 and 3 should have to be done once since refresh_rate and
> > > update_interval would interfere with each other otherwise.
> >
> > Well, between 1 and 3 both old and new API are active. Shouldn't be
> > much of a problem because the GraphicHwOps implementations are using
> > only the one or the other.
> >
> > take care,
> > Gerd
> >
>
> The only GraphicHwOps implementation updated with this change is xenfb.
> xenfb can be switched to use refresh_rate in step 1 or 3.
>
> Switching to use refresh_rate in step 1 would break the refresh rate
> propagation until all host displays are updated to set refresh_rate instead
> of calling update_interval.
Well, host display update would need splitting into two pieces too,
first add refresh_rate, then later drop update_interval, to make the
update scheme work without temporary breakage.
That sounds increasingly like over engineering it though, I guess I just
queue up the patches as-is.
thanks,
Gerd