[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/4] target/riscv: Force disable extensions if priv spec v
|
From: |
Anup Patel |
|
Subject: |
Re: [PATCH v4 4/4] target/riscv: Force disable extensions if priv spec version does not match |
|
Date: |
Thu, 9 Jun 2022 21:50:56 +0530 |
On Thu, Jun 9, 2022 at 7:28 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 6/8/22 20:16, Anup Patel wrote:
> > On Wed, Jun 8, 2022 at 10:23 PM Richard Henderson
> > <richard.henderson@linaro.org> wrote:
> >>
> >> On 6/8/22 09:14, Anup Patel wrote:
> >>> + struct isa_ext_data isa_edata_arr[] = {
> >>
> >> static const?
> >
> > Using const is fine but we can't use "static const" because
> > the "struct isa_ext_data" has a pointer to ext_xyz which
> > is different for each CPU.
>
> Ah, I see. Perhaps better to use offsetof then -- the data structure is not
> small...
I agree. Using offsetof() is a much better approach.
Thanks,
Anup
>
>
> r~