[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] dbus-display: fix test race when initializing p2p connection
|
From: |
Cole Robinson |
|
Subject: |
Re: [PATCH] dbus-display: fix test race when initializing p2p connection |
|
Date: |
Sat, 11 Jun 2022 16:21:04 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 |
On 6/9/22 11:26 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The D-Bus connection starts processing messages before QEMU has the time
> to set the object manager server. This is causing dbus-display-test to
> fail randomly with:
>
> ERROR:../tests/qtest/dbus-display-test.c:68:test_dbus_display_vm:
> assertion failed
> (qemu_dbus_display1_vm_get_name(QEMU_DBUS_DISPLAY1_VM(vm)) ==
> "dbus-test"): (NULL == "dbus-test") ERROR
>
> Use the delayed message processing flag and method to avoid that
> situation.
>
> (the bus connection doesn't need a fix, as the initialization is done
> synchronously)
>
> Reported-by: Robinson, Cole <crobinso@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/dbus.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Fedora test build passed for me. Thanks Marc-André!
Tested-by: Cole Robinson <crobinso@redhat.com>
- Cole