|
From: | Richard Henderson |
Subject: | Re: [PATCH 08/11] bsd-user: Implement rmdir and undocumented -_getcwd |
Date: | Mon, 13 Jun 2022 12:52:35 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 6/12/22 13:48, Warner Losh wrote:
Implemenet rmdir and __getcwd. Declare __getcwd as extern because there's no installed FreeBSD header that has it. It's used internally by libc, which doesn't provide an external declaration, but does export the symbol.
Typo in subject: s/-/_/.
@@ -55,6 +55,7 @@ extern struct iovec *lock_iovec(int type, abi_ulong target_addr, int count, int copy); extern void unlock_iovec(struct iovec *vec, abi_ulong target_addr, int count, int copy); +extern int __getcwd(char *path, size_t len);
Do you really want to rely on this export?Unless it does something special, I'd just declare a local version of the syscall as you do with safe_*.
+/* undocumented __getcwd(char *buf, size_t len) system call */
Surely the syscall itself is documented? r~
[Prev in Thread] | Current Thread | [Next in Thread] |