[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/7] gitlab: compare CIRRUS_nn vars against 'null' not ""
From: |
Alex Bennée |
Subject: |
[PULL 6/7] gitlab: compare CIRRUS_nn vars against 'null' not "" |
Date: |
Tue, 14 Jun 2022 01:42:08 +0100 |
From: Daniel P. Berrangé <berrange@redhat.com>
The GitLab variable comparisons don't have shell like semantics where
an unset variable compares equal to empty string. We need to explicitly
test against 'null' to detect an unset variable.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220608160651.248781-1-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20220613171258.1905715-7-alex.bennee@linaro.org>
diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml
index f334f3ded7..69b36c148a 100644
--- a/.gitlab-ci.d/base.yml
+++ b/.gitlab-ci.d/base.yml
@@ -13,7 +13,7 @@
#############################################################
# Cirrus jobs can't run unless the creds / target repo are set
- - if: '$QEMU_JOB_CIRRUS && ($CIRRUS_GITHUB_REPO == "" || $CIRRUS_API_TOKEN
== "")'
+ - if: '$QEMU_JOB_CIRRUS && ($CIRRUS_GITHUB_REPO == null ||
$CIRRUS_API_TOKEN == null)'
when: never
# Publishing jobs should only run on the default branch in upstream
--
2.30.2
- [PULL 0/7] testing/next (docker, gitlab,tcg), Alex Bennée, 2022/06/13
- [PULL 3/7] gitlab-ci: Fix the build-cfi-aarch64 and build-cfi-ppc64-s390x jobs, Alex Bennée, 2022/06/13
- [PULL 1/7] test/tcg/arm: Use -mfloat-abi=soft for test-armv6m-undef, Alex Bennée, 2022/06/13
- [PULL 5/7] tests/tcg: disable xtensa-linux-user again, Alex Bennée, 2022/06/13
- [PULL 6/7] gitlab: compare CIRRUS_nn vars against 'null' not "",
Alex Bennée <=
- [PULL 2/7] tests/tcg/i386: Use explicit suffix on fist insns, Alex Bennée, 2022/06/13
- [PULL 4/7] tests/docker: fix the IMAGE for build invocation, Alex Bennée, 2022/06/13
- [PULL 7/7] .gitlab: use less aggressive nproc on our aarch64/32 runners, Alex Bennée, 2022/06/13
- Re: [PULL 0/7] testing/next (docker, gitlab,tcg), Richard Henderson, 2022/06/14