Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

[David Hildenbrand]

On 14.06.22 10:54, Igor Mammedov wrote:
> On Mon, 13 Jun 2022 16:09:53 +0100
> Stefan Hajnoczi <stefanha@redhat.com> wrote:
> 
>> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote:
>>> On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi <stefanha@redhat.com> 
>>> wrote:  
>>>>
>>>> On Tue, May 31, 2022 at 04:51:47PM +0200, Julia Suvorova wrote:  
>>>>> In the ACPI specification [1], the 'unarmed' bit is set when a device
>>>>> cannot accept a persistent write. This means that when a memdev is
>>>>> read-only, the 'unarmed' flag must be turned on. The logic is correct,
>>>>> just changing the error message.
>>>>>
>>>>> [1] ACPI NFIT NVDIMM Region Mapping Structure "NVDIMM State Flags" Bit 3
>>>>>
>>>>> Signed-off-by: Julia Suvorova <jusual@redhat.com>
>>>>> ---
>>>>>  hw/mem/nvdimm.c | 2 +-
>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)  
>>>>
>>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>  
>>>
>>> It seems like Xiao is not active, whose tree should this patch go to?  

Is that a temporary or a permanent thing? Do we know?

> 
> Perhaps David can add himself as maintainer (i.e. put it
> under memory mantanership umbrella) and merge it 

Maybe it makes sense to combine NVDIMM with pc-dimm.c and
memory-device.c into a "MEMORY DEVICE" section. Then, remove "hw/mem/*"
from "ACPI/SMBIOS".

cxl_type3.c, npcm7xx_mc.c and sparse-mem.c in /hw/mem/ are a bit
different. We could add cxl_type3.c to "Compute Express Link".
npcm7xx_mc.c and sparse-mem.c should be already covered.

-- 
Thanks,

David / dhildenb