[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/10] block: use 'unsigned' for in_flight field on driver state
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PULL 09/10] block: use 'unsigned' for in_flight field on driver state |
Date: |
Tue, 14 Jun 2022 13:29:09 +0300 |
From: "Denis V. Lunev" <den@openvz.org>
This patch makes in_flight field 'unsigned' for BDRVNBDState and
MirrorBlockJob. This matches the definition of this field on BDS
and is generically correct - we should never get negative value here.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: John Snow <jsnow@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Hanna Reitz <hreitz@redhat.com>
CC: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
block/mirror.c | 2 +-
block/nbd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index d8ecb9efa2..3c4ab1159d 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -73,7 +73,7 @@ typedef struct MirrorBlockJob {
uint64_t last_pause_ns;
unsigned long *in_flight_bitmap;
- int in_flight;
+ unsigned in_flight;
int64_t bytes_in_flight;
QTAILQ_HEAD(, MirrorOp) ops_in_flight;
int ret;
diff --git a/block/nbd.c b/block/nbd.c
index bc8f128087..19e773d602 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -77,7 +77,7 @@ typedef struct BDRVNBDState {
QemuMutex requests_lock;
NBDClientState state;
CoQueue free_sema;
- int in_flight;
+ unsigned in_flight;
NBDClientRequest requests[MAX_NBD_REQUESTS];
QEMUTimer *reconnect_delay_timer;
--
2.25.1
- [PULL 00/10] Block jobs & NBD patches, Vladimir Sementsov-Ogievskiy, 2022/06/14
- [PULL 01/10] block/copy-before-write: refactor option parsing, Vladimir Sementsov-Ogievskiy, 2022/06/14
- [PULL 02/10] block/copy-before-write: add on-cbw-error open parameter, Vladimir Sementsov-Ogievskiy, 2022/06/14
- [PULL 04/10] util: add qemu-co-timeout, Vladimir Sementsov-Ogievskiy, 2022/06/14
- [PULL 05/10] block/block-copy: block_copy(): add timeout_ns parameter, Vladimir Sementsov-Ogievskiy, 2022/06/14
- [PULL 07/10] iotests: copy-before-write: add cases for cbw-timeout option, Vladimir Sementsov-Ogievskiy, 2022/06/14
- [PULL 03/10] iotests: add copy-before-write: on-cbw-error tests, Vladimir Sementsov-Ogievskiy, 2022/06/14
- [PULL 08/10] nbd: trace long NBD operations, Vladimir Sementsov-Ogievskiy, 2022/06/14
- [PULL 06/10] block/copy-before-write: implement cbw-timeout option, Vladimir Sementsov-Ogievskiy, 2022/06/14
- [PULL 09/10] block: use 'unsigned' for in_flight field on driver state,
Vladimir Sementsov-Ogievskiy <=
- [PULL 10/10] MAINTAINERS: update Vladimir's address and repositories, Vladimir Sementsov-Ogievskiy, 2022/06/14
- Re: [PULL 00/10] Block jobs & NBD patches, Richard Henderson, 2022/06/14