qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] configure: cleanup -fno-pie detection


From: Richard Henderson
Subject: Re: [PATCH] configure: cleanup -fno-pie detection
Date: Tue, 14 Jun 2022 09:55:12 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1

On 6/14/22 07:50, Paolo Bonzini wrote:
Place it only inside the 'if test "$pie" = "no"' conditional.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
  configure | 13 ++++---------
  1 file changed, 4 insertions(+), 9 deletions(-)

Worth mentioning 43924d1e53f, which obviated...

-# Check we support -fno-pie and -no-pie first; we will need the former for
-# building ROMs, and both for everything if --disable-pie is passed.

... this comment.

Either "Fixes:" or just in the text, "Since XXX, we no longer require this probe for building ROMs".

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]