Re: [PATCH v16 3/9] linux-user: Add LoongArch elf support

[gaosong]

Hi Richard.

On 2022/6/15 上午12:21, Richard Henderson wrote:

> On
>       6/14/22 02:05, Song Gao wrote:
>       
> > +#define ELF_HWCAP
> >         get_elf_hwcap()
> >         
> >         +
> >         
> >         +static uint32_t get_elf_hwcap(void)
> >         
> >         +{
> >         
> >         +    return 0;
> >         
> >         +}
> >         
> >       
>       
>       This should not be zero.  See cpu_probe_common in the kernel.  At
>       minimum HWCAP_LOONGARCH_CRC32 and HWCAP_LOONGARCH_FPU are
>       missing.  I don't know how many of the other features are
>       implemented in target/loongarch/.
>       
>       
>     
    HWCAP_LOONGARCH_LAM  and  HWCAP_LOONGARCH_UAL  are need. 
> Missing
>       ELF_PLATFORM, per the kernel's set_elf_platform(cpu, "loongarch").
>       
>     
    OK,  I will correct on next version.
    
    Thanks.
    Song Gao