[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH v3 0/2] hw/nvme: Add shadow doorbell buffer support |
|
Date: |
Fri, 17 Jun 2022 14:35:22 -0600 |
On Thu, Jun 16, 2022 at 08:34:06PM +0800, Jinhao Fan wrote:
> This patch adds shadow doorbell buffer support in NVMe 1.3 to QEMU
> NVMe. The Doorbell Buffer Config admin command is implemented for the
> guest to enable shadow doobell buffer. When this feature is enabled, each
> SQ/CQ is associated with two buffers, i.e., Shadow Doorbell buffer and
> EventIdx buffer. According to the Spec, each queue's doorbell register
> is only updated when the Shadow Doorbell buffer value changes from being
> less than or equal to the value of the corresponding EventIdx buffer
> entry to being greater than that value. Therefore, the number of MMIO's
> on the doorbell registers is greatly reduced.
Looks good to me, and passes my sanity tests.
Reviewed-by: Keith Busch <kbusch@kernel.org>