[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] device_tree: add qemu_fdt_setprop_strings() helper
From: |
Alistair Francis |
Subject: |
Re: [PATCH 3/4] device_tree: add qemu_fdt_setprop_strings() helper |
Date: |
Mon, 20 Jun 2022 16:47:20 +1000 |
On Sun, Jun 19, 2022 at 6:20 AM Ben Dooks <qemu@ben.fluff.org> wrote:
>
> Add a helper to set a property from a set of strings
> to reduce the following code:
>
> static const char * const clint_compat[2] = {
> "sifive,clint0", "riscv,clint0"
> };
>
> qemu_fdt_setprop_string_array(fdt, nodename, "compatible",
> (char **)&clint_compat, ARRAY_SIZE(clint_compat));
>
> Signed-off-by: Ben Dooks <qemu@ben.fluff.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> --
> v2:
> - fix node/path in comment
> ---
> include/sysemu/device_tree.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/include/sysemu/device_tree.h b/include/sysemu/device_tree.h
> index 79ce009a22..28b68bacaf 100644
> --- a/include/sysemu/device_tree.h
> +++ b/include/sysemu/device_tree.h
> @@ -87,6 +87,21 @@ int qemu_fdt_setprop_string(void *fdt, const char
> *node_path,
> int qemu_fdt_setprop_string_array(void *fdt, const char *node_path,
> const char *prop, char **array, int len);
>
> +/**
> + * qemu_fdt_setprop_strings: set a property from a set of strings
> + *
> + * @fdt: pointer to the dt blob
> + * @path: node name
> + * @prop: property array
> + */
> +#define qemu_fdt_setprop_strings(fdt, path, prop, ...) \
> + do { \
> + static const char * const __strs[] = { __VA_ARGS__ }; \
> + qemu_fdt_setprop_string_array(fdt, path, prop, \
> + (char **)&__strs, ARRAY_SIZE(__strs)); \
> + } while(0)
> +
> +
> int qemu_fdt_setprop_phandle(void *fdt, const char *node_path,
> const char *property,
> const char *target_node_path);
> --
> 2.35.1
>
>