Re: [PATCH v7 1/6] qga: Relocate a path emitted in the help text

[Marc-André Lureau]

Hi

On Mon, Jun 20, 2022 at 5:11 PM Marc-André Lureau <marcandre.lureau@gmail.com> wrote:

On Wed, Jun 15, 2022 at 9:43 PM Akihiko Odaki <akihiko.odaki@gmail.com> wrote:

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

 

Oops, could you avoid leaking the result? g_autofree makes that easy.

thanks

 

---
 qga/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/main.c b/qga/main.c
index c373fec3ee6..06e507b9979 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -270,7 +270,7 @@ QEMU_HELP_BOTTOM "\n"
     , cmd, QGA_VIRTIO_PATH_DEFAULT, QGA_SERIAL_PATH_DEFAULT,
     dfl_pathnames.pidfile,
 #ifdef CONFIG_FSFREEZE
-    QGA_FSFREEZE_HOOK_DEFAULT,
+    get_relocated_path(QGA_FSFREEZE_HOOK_DEFAULT),
 #endif
     dfl_pathnames.state_dir);
 }
--
2.32.1 (Apple Git-133)

--

Marc-André Lureau

--

Marc-André Lureau