[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/21] migration: convert savevm to use QIOChannelBlock fo
From: |
Juan Quintela |
Subject: |
Re: [PATCH v2 10/21] migration: convert savevm to use QIOChannelBlock for VMState |
Date: |
Mon, 20 Jun 2022 17:19:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Daniel P. Berrangé <berrange@redhat.com> wrote:
> With this change, all QEMUFile usage is backed by QIOChannel at
> last.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> {
> if (is_writable) {
> - return qemu_fopen_ops(bs, &bdrv_write_ops, false);
> + return
> qemu_fopen_channel_output(QIO_CHANNEL(qio_channel_block_new(bs)));
> + } else {
> + return
> qemu_fopen_channel_input(QIO_CHANNEL(qio_channel_block_new(bs)));
> }
> - return qemu_fopen_ops(bs, &bdrv_read_ops, false);
> }
I really preffer the original syntax:
if (is_writable) {
return
qemu_fopen_channel_output(QIO_CHANNEL(qio_channel_block_new(bs)));
}
return qemu_fopen_channel_input(QIO_CHANNEL(qio_channel_block_new(bs)));
But as you wrote the patch, and it is a big cleanup, I will not
complain.
Later, Juan.
- Re: [PATCH v2 03/21] migration: remove unreachble RDMA code in save_hook impl, (continued)
- [PATCH v2 04/21] migration: rename rate limiting fields in QEMUFile, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 06/21] migration: rename qemu_ftell to qemu_file_total_transferred, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 05/21] migration: rename 'pos' field in QEMUFile to 'bytes_processed', Daniel P . Berrangé, 2022/06/20
- [PATCH v2 07/21] migration: rename qemu_update_position to qemu_file_credit_transfer, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 10/21] migration: convert savevm to use QIOChannelBlock for VMState, Daniel P . Berrangé, 2022/06/20
- Re: [PATCH v2 10/21] migration: convert savevm to use QIOChannelBlock for VMState,
Juan Quintela <=
- [PATCH v2 09/21] migration: introduce a QIOChannel impl for BlockDriverState VMState, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 18/21] migration: remove the QEMUFileOps 'get_buffer' callback, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 11/21] migration: stop passing 'opaque' parameter to QEMUFile hooks, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 12/21] migration: hardcode assumption that QEMUFile is backed with QIOChannel, Daniel P . Berrangé, 2022/06/20