[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 19/21] migration: remove the QEMUFileOps 'writev_buffer' c
From: |
Juan Quintela |
Subject: |
Re: [PATCH v2 19/21] migration: remove the QEMUFileOps 'writev_buffer' callback |
Date: |
Mon, 20 Jun 2022 17:43:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Daniel P. Berrangé <berrange@redhat.com> wrote:
> This directly implements the writev_buffer logic using QIOChannel APIs.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
<this comment applies to more patches on this series>
> - expect = iov_size(f->iov, f->iovcnt);
> - ret = f->ops->writev_buffer(f->ioc, f->iov, f->iovcnt,
> f->total_transferred,
> - &local_error);
> + Error *local_error = NULL;
> + if (qio_channel_writev_all(f->ioc,
> + f->iov, f->iovcnt,
> + &local_error) < 0) {
Why are you splitting this line like this?
It should be ok in two lines, I think it is just 82 chars long, right?
Later, Juan.
- Re: [PATCH v2 11/21] migration: stop passing 'opaque' parameter to QEMUFile hooks, (continued)
- [PATCH v2 12/21] migration: hardcode assumption that QEMUFile is backed with QIOChannel, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 13/21] migration: introduce new constructors for QEMUFile, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 16/21] migration: remove the QEMUFileOps 'set_blocking' callback, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 15/21] migration: remove the QEMUFileOps 'shut_down' callback, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 19/21] migration: remove the QEMUFileOps 'writev_buffer' callback, Daniel P . Berrangé, 2022/06/20
- Re: [PATCH v2 19/21] migration: remove the QEMUFileOps 'writev_buffer' callback,
Juan Quintela <=
- [PATCH v2 17/21] migration: remove the QEMUFileOps 'close' callback, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 20/21] migration: remove the QEMUFileOps 'get_return_path' callback, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 21/21] migration: remove the QEMUFileOps abstraction, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 14/21] migration: remove unused QEMUFileGetFD typedef / qemu_get_fd method, Daniel P . Berrangé, 2022/06/20
- [PATCH v2 08/21] migration: rename qemu_file_update_transfer to qemu_file_acct_rate_limit, Daniel P . Berrangé, 2022/06/20