qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/i386: Add unaccepted memory configuration


From: Michael S. Tsirkin
Subject: Re: [PATCH] hw/i386: Add unaccepted memory configuration
Date: Tue, 21 Jun 2022 02:04:37 -0400

On Tue, Jun 21, 2022 at 07:37:02AM +0200, Gerd Hoffman wrote:
> On Mon, Jun 20, 2022 at 10:33:00PM +0000, Dionna Glaze wrote:
> > For SEV-SNP, an OS is "SEV-SNP capable" without supporting this UEFI
> > v2.9 memory type. In order for OVMF to be able to avoid pre-validating
> > potentially hundreds of gibibytes of data before booting, it needs to
> > know if the guest OS can support its use of the new type of memory in
> > the memory map.
> 
> I think this should be wired up via sev-guest object (see
> SevGuestProperties in qapi/qom.json and target/i386/sev.c),
> i.e.
> 
> qemu -object sev-guest,accept-all-memory=true,$args
> 
> (and likewise for -object tdx-guest once merged).
> 
> take care,
>   Gerd

Right. As written the patch would allow the flag without SEV-SNP too -
but does it make any sense outside SEV-SNP? It's better not to allow
flag combinations that make no sense since they tend to
become part of ABI that we then need to support.

-- 
MST




reply via email to

[Prev in Thread] Current Thread [Next in Thread]