[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/4] migration: zero-copy flush only at the end of bitmap
From: |
Peter Xu |
Subject: |
Re: [PATCH v4 3/4] migration: zero-copy flush only at the end of bitmap scanning |
Date: |
Tue, 21 Jun 2022 11:09:10 -0400 |
On Tue, Jun 21, 2022 at 04:51:39PM +0200, Juan Quintela wrote:
> > IIRC, the kernel will fall back to copying only if the network adapter /
> > driver
> > does not support MSG_ZEROCOPY, like when it does not support scatter-gather.
>
> My understanding is that it will fallback when you have too much stuff
> inflight.
I think we'd better figure this out soon, because if so then IMHO we can't
simply fail the migration when the fallback happens.. If we're not sure
about that, we can always be on the safe side to dump an error only.
--
Peter Xu
[PATCH v4 1/4] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability, Leonardo Bras, 2022/06/20
[PATCH v4 2/4] QIOChannelSocket: Fix zero-copy send so socket flush works, Leonardo Bras, 2022/06/20
[PATCH v4 4/4] migration: Change zero_copy_send from migration parameter to migration capability, Leonardo Bras, 2022/06/20