[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v4 05/11] net: stream: Don't ignore EINVAL on netdev socket c
From: |
Laurent Vivier |
Subject: |
[RFC PATCH v4 05/11] net: stream: Don't ignore EINVAL on netdev socket connection |
Date: |
Thu, 23 Jun 2022 17:53:11 +0200 |
From: Stefano Brivio <sbrivio@redhat.com>
Other errors are treated as failure by net_stream_client_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
[lvivier: applied to net/stream.c]
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
net/stream.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/stream.c b/net/stream.c
index 0d012ed8f785..d991fe3ac2b9 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -366,8 +366,7 @@ static int net_stream_client_init(NetClientState *peer,
if (errno == EINTR || errno == EWOULDBLOCK) {
/* continue */
} else if (errno == EINPROGRESS ||
- errno == EALREADY ||
- errno == EINVAL) {
+ errno == EALREADY) {
break;
} else {
error_setg_errno(errp, errno, "can't connect socket");
--
2.36.1
- [RFC PATCH v4 00/11] qapi: net: add unix socket type support to netdev backend, Laurent Vivier, 2022/06/23
- [RFC PATCH v4 01/11] net: introduce convert_host_port(), Laurent Vivier, 2022/06/23
- [RFC PATCH v4 02/11] net: remove the @errp argument of net_client_inits(), Laurent Vivier, 2022/06/23
- [RFC PATCH v4 03/11] qapi: net: introduce a way to bypass qemu_opts_parse_noisily(), Laurent Vivier, 2022/06/23
- [RFC PATCH v4 05/11] net: stream: Don't ignore EINVAL on netdev socket connection,
Laurent Vivier <=
- [RFC PATCH v4 06/11] net: stream: add unix socket, Laurent Vivier, 2022/06/23
- [RFC PATCH v4 04/11] qapi: net: add stream and dgram netdevs, Laurent Vivier, 2022/06/23
- Re: [RFC PATCH v4 04/11] qapi: net: add stream and dgram netdevs, Markus Armbruster, 2022/06/24
- [RFC PATCH v4 09/11] net: dgram: add unix socket, Laurent Vivier, 2022/06/23
- [RFC PATCH v4 11/11] net: stream: move to QIO, Laurent Vivier, 2022/06/23
- [RFC PATCH v4 08/11] net: dgram: move mcast specific code from net_socket_fd_init_dgram(), Laurent Vivier, 2022/06/23
- [RFC PATCH v4 07/11] net: dgram: make dgram_dst generic, Laurent Vivier, 2022/06/23