[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] docs/system/devices/canokey: Document limitations on
From: |
Hongren Zheng |
Subject: |
Re: [PATCH v3 2/2] docs/system/devices/canokey: Document limitations on usb-ehci |
Date: |
Sat, 25 Jun 2022 00:11:05 +0800 |
On Fri, Jun 24, 2022 at 11:29:40PM +0800, MkfsSion wrote:
>
> -Another limitation is that this device is not compatible with ``qemu-xhci``,
> -in that this device would hang when there are FIDO2 packets (traffic on
> -interrupt endpoints). If you do not use FIDO2 then it works as intended,
> -but for full functionality you should use old uhci/ehci bus and attach
> canokey
> -to it, for example
> -
> -.. parsed-literal::
> -
> - |qemu_system| -device piix3-usb-uhci,id=uhci -device canokey,bus=uhci.0
Hi, the fix for the limitation on qemu-xhci has not been landed and should not
be removed by this patch.
> +Another limitation is that this device is not compatible with ``usb-ehci``
> +since we removed high-speed mode support. When a full-speed device attach
> +to a high-speed port, ``usb-ehci`` would complain about speed mismatch.
I think we could rephrase the limitation here. Instead of saying "we
removed the high-speed mode", how about saying "this device only
provides the full-speed mode".
Also you should list the changes between two PATCH versions
below the --- line just after your commit message
so the mailing list can track what happened.
Regards,
Hongren