[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 11/15] Revert "block: Restructure remove_file_or_backing_child
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v6 11/15] Revert "block: Restructure remove_file_or_backing_child()" |
Date: |
Sat, 25 Jun 2022 00:28:26 +0300 |
That's a preparation to previously reverted
"block: Let replace_child_noperm free children". Drop it too, we don't
need it for a new approach.
This reverts commit 562bda8bb41879eeda0bd484dd3d55134579b28e.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
block.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/block.c b/block.c
index a83845b120..3ac332a460 100644
--- a/block.c
+++ b/block.c
@@ -5051,33 +5051,30 @@ static void
bdrv_remove_file_or_backing_child(BlockDriverState *bs,
BdrvChild *child,
Transaction *tran)
{
- BdrvChild **childp;
BdrvRemoveFilterOrCowChild *s;
+ assert(child == bs->backing || child == bs->file);
+
if (!child) {
return;
}
- if (child == bs->backing) {
- childp = &bs->backing;
- } else if (child == bs->file) {
- childp = &bs->file;
- } else {
- g_assert_not_reached();
- }
-
if (child->bs) {
- bdrv_replace_child_tran(*childp, NULL, tran);
+ bdrv_replace_child_tran(child, NULL, tran);
}
s = g_new(BdrvRemoveFilterOrCowChild, 1);
*s = (BdrvRemoveFilterOrCowChild) {
.child = child,
- .is_backing = (childp == &bs->backing),
+ .is_backing = (child == bs->backing),
};
tran_add(tran, &bdrv_remove_filter_or_cow_child_drv, s);
- *childp = NULL;
+ if (s->is_backing) {
+ bs->backing = NULL;
+ } else {
+ bs->file = NULL;
+ }
}
/*
--
2.25.1
- [PATCH v6 01/15] block: BlockDriver: add .filtered_child_is_backing field, (continued)
- [PATCH v6 01/15] block: BlockDriver: add .filtered_child_is_backing field, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 03/15] block/blklogwrites: don't care to remove bs->file child on failure, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 02/15] block: introduce bdrv_open_file_child() helper, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 04/15] test-bdrv-graph-mod: update test_parallel_perm_update test case, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 07/15] block: document connection between child roles and bs->backing/bs->file, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 09/15] Revert "block: Let replace_child_noperm free children", Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 05/15] tests-bdrv-drain: bdrv_replace_test driver: declare supports_backing, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 06/15] test-bdrv-graph-mod: fix filters to be filters, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 08/15] block/snapshot: stress that we fallback to primary child, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 10/15] Revert "block: Let replace_child_tran keep indirect pointer", Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 11/15] Revert "block: Restructure remove_file_or_backing_child()",
Vladimir Sementsov-Ogievskiy <=
- [PATCH v6 12/15] Revert "block: Pass BdrvChild ** to replace_child_noperm", Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 15/15] block: refactor bdrv_remove_file_or_backing_child to bdrv_remove_child, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 13/15] block: Manipulate bs->file / bs->backing pointers in .attach/.detach, Vladimir Sementsov-Ogievskiy, 2022/06/24
- [PATCH v6 14/15] block/snapshot: drop indirection around bdrv_snapshot_fallback_ptr, Vladimir Sementsov-Ogievskiy, 2022/06/24
- Re: [PATCH v6 00/15] block: cleanup backing and file handling, Hanna Reitz, 2022/06/30