qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memf


From: Alex Bennée
Subject: Re: [PATCH] tcg: Fix returned type in alloc_code_gen_buffer_splitwx_memfd()
Date: Sat, 25 Jun 2022 17:32:42 +0100
User-agent: mu4e 1.7.27; emacs 28.1.50

Shaobo Song <shnusongshaobo@gmail.com> writes:

>  This fixes a bug in POSIX-compliant environments. Since we had allocated 
>  a buffer named 'tcg-jit' with read-write access protections we need a int 
>  type to combine these access flags and return it, whereas we had 
> inexplicably 
>  return a bool type. It may cause an unnecessary protection change in 
>  tcg_region_init().
>
> Signed-off-by: Shaobo Song <shnusongshaobo@gmail.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]