Re: [PATCH 04/12] acpi/tests/bits: initial commit of test scripts that are run by biosbits

[Michael S. Tsirkin]

On Tue, Jun 28, 2022 at 09:24:19AM +0200, Thomas Huth wrote:

... 3000 lines of irrelevant code ...


> > diff --git a/tests/qtest/acpi-bits/bits-tests/testcpuid.py 
> > b/tests/qtest/acpi-bits/bits-tests/testcpuid.py
> > new file mode 100644
> > index 0000000000..ac55d912e1
> > --- /dev/null
> > +++ b/tests/qtest/acpi-bits/bits-tests/testcpuid.py
> > @@ -0,0 +1,83 @@
> > +# Copyright (c) 2012, Intel Corporation
> > +# All rights reserved.
> > +#
> > +# Redistribution and use in source and binary forms, with or without
> > +# modification, are permitted provided that the following conditions are 
> > met:
> > +#
> > +#     * Redistributions of source code must retain the above copyright 
> > notice,
> > +#       this list of conditions and the following disclaimer.
> > +#     * Redistributions in binary form must reproduce the above copyright 
> > notice,
> > +#       this list of conditions and the following disclaimer in the 
> > documentation
> > +#       and/or other materials provided with the distribution.
> > +#     * Neither the name of Intel Corporation nor the names of its 
> > contributors
> > +#       may be used to endorse or promote products derived from this 
> > software
> > +#       without specific prior written permission.
> > +#
> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
> > IS" AND
> > +# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
> > IMPLIED
> > +# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> > +# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE 
> > LIABLE FOR
> > +# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
> > DAMAGES
> > +# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR 
> > SERVICES;
> > +# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED 
> > AND ON
> > +# ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 
> > THIS
> > +# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> Could you do me a favour and add a SPDX license identifier in front of the
> license boilerplate codes?
> 
> It's not required for the QEMU project, but at least I normally have
> troubles to find out what such longer license boilertexts mean ... is it a
> BSD license, is it a MIT license, something completely else...? A short SPDX
> line at the beginning helps to identify the license at a first glance.
> 
>  Thomas

Pls remember to cut out irrelevant text when you respond.

Thanks,
-- 
MST