Re: [PATCH] gtk: Add show_tabs=on|off command line option.

[Hanna Reitz]

On 30.06.22 16:09, Hanna Reitz wrote:
> Hi,
>
> (Thanks for the patch!)
>
> On 27.06.22 18:44, Felix xq Queißner wrote:
> > The patch adds "show_tabs" command line option for GTK ui similar to 
> > "grab_on_hover". This option allows tabbed view mode to not have to 
> > be enabled by hand at each start of the VM.
>
> I’m not sure we have a hard rule on it, but I think generally commit 
> messages should be wrapped at 72 characters.
>
> > Signed-off-by: Felix "xq" Queißner <xq@random-projects.net>
> > ---
> >   qapi/ui.json    | 5 ++++-
> >   qemu-options.hx | 2 +-
> >   ui/gtk.c        | 4 ++++
> >   3 files changed, 9 insertions(+), 2 deletions(-)

[...]

> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 377d22fbd8..2b279afff7 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -1937,7 +1937,7 @@ DEF("display", HAS_ARG, QEMU_OPTION_display,
> >       "            [,window-close=on|off]\n"
> >   #endif
> >   #if defined(CONFIG_GTK)
> > -    "-display 
> > gtk[,full-screen=on|off][,gl=on|off][,grab-on-hover=on|off]\n"
> > +    "-display 
> > gtk[,full-screen=on|off][,gl=on|off][,grab-on-hover=on|off][,show-tabs=on|off]\n"
> >       " [,show-cursor=on|off][,window-close=on|off]\n"

Oops, noticed another thing (a bit late): Considering the options are 
already spit over two lines, it looks to me like this line’s length is 
supposed to be limited.  (My guess is we’re trying to not exceed 80 
characters here in this source file.)  Therefore, this new option should 
probably go on a separate new line.

Hanna