[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 5/8] migration: Export dirty-limit time info
From: |
huangy81 |
Subject: |
[PATCH v1 5/8] migration: Export dirty-limit time info |
Date: |
Fri, 2 Sep 2022 01:22:33 +0800 |
From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
Export dirty limit throttle time and estimated ring full
time, through which we can observe the process of dirty
limit during live migration.
Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
---
include/sysemu/dirtylimit.h | 2 ++
migration/migration.c | 10 ++++++++++
monitor/hmp-cmds.c | 10 ++++++++++
qapi/migration.json | 10 +++++++++-
softmmu/dirtylimit.c | 22 ++++++++++++++++++++++
5 files changed, 53 insertions(+), 1 deletion(-)
diff --git a/include/sysemu/dirtylimit.h b/include/sysemu/dirtylimit.h
index 8d2c1f3..98cc4a6 100644
--- a/include/sysemu/dirtylimit.h
+++ b/include/sysemu/dirtylimit.h
@@ -34,4 +34,6 @@ void dirtylimit_set_vcpu(int cpu_index,
void dirtylimit_set_all(uint64_t quota,
bool enable);
void dirtylimit_vcpu_execute(CPUState *cpu);
+int64_t dirtylimit_throttle_us_per_full(void);
+int64_t dirtylimit_us_ring_full(void);
#endif
diff --git a/migration/migration.c b/migration/migration.c
index 64696de..22ba197 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -61,6 +61,7 @@
#include "sysemu/cpus.h"
#include "yank_functions.h"
#include "sysemu/qtest.h"
+#include "sysemu/dirtylimit.h"
#define MAX_THROTTLE (128 << 20) /* Migration transfer speed throttling
*/
@@ -1110,6 +1111,15 @@ static void populate_ram_info(MigrationInfo *info,
MigrationState *s)
info->ram->remaining = ram_bytes_remaining();
info->ram->dirty_pages_rate = ram_counters.dirty_pages_rate;
}
+
+ if (migrate_dirty_limit() && dirtylimit_in_service()) {
+ info->has_dirty_limit_throttle_us_per_full = true;
+ info->dirty_limit_throttle_us_per_full =
+ dirtylimit_throttle_us_per_full();
+
+ info->has_dirty_limit_us_ring_full = true;
+ info->dirty_limit_us_ring_full = dirtylimit_us_ring_full();
+ }
}
static void populate_disk_info(MigrationInfo *info)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index b362fae..23c3f48 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -358,6 +358,16 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
info->cpu_throttle_percentage);
}
+ if (info->has_dirty_limit_throttle_us_per_full) {
+ monitor_printf(mon, "dirty-limit throttle time: %" PRIu64 " us\n",
+ info->dirty_limit_throttle_us_per_full);
+ }
+
+ if (info->has_dirty_limit_us_ring_full) {
+ monitor_printf(mon, "dirty-limit ring full time: %" PRIu64 " us\n",
+ info->dirty_limit_us_ring_full);
+ }
+
if (info->has_postcopy_blocktime) {
monitor_printf(mon, "postcopy blocktime: %u\n",
info->postcopy_blocktime);
diff --git a/qapi/migration.json b/qapi/migration.json
index bc4bc96..c263d54 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -242,6 +242,12 @@
# Present and non-empty when migration is blocked.
# (since 6.0)
#
+# @dirty-limit-throttle-us-per-full: Throttle time (us) during the period of
+# dirty ring full (since 7.0)
+#
+# @dirty-limit-us-ring-full: Estimated periodic time (us) of dirty ring full.
+# (since 7.0)
+#
# Since: 0.14
##
{ 'struct': 'MigrationInfo',
@@ -259,7 +265,9 @@
'*postcopy-blocktime' : 'uint32',
'*postcopy-vcpu-blocktime': ['uint32'],
'*compression': 'CompressionStats',
- '*socket-address': ['SocketAddress'] } }
+ '*socket-address': ['SocketAddress'],
+ '*dirty-limit-throttle-us-per-full': 'int64',
+ '*dirty-limit-us-ring-full': 'int64'} }
##
# @query-migrate:
diff --git a/softmmu/dirtylimit.c b/softmmu/dirtylimit.c
index 1fdd8c6..1251b27 100644
--- a/softmmu/dirtylimit.c
+++ b/softmmu/dirtylimit.c
@@ -546,6 +546,28 @@ static struct DirtyLimitInfo *dirtylimit_query_vcpu(int
cpu_index)
return info;
}
+/* Pick up first vcpu throttle time by default */
+int64_t dirtylimit_throttle_us_per_full(void)
+{
+ CPUState *cpu = first_cpu;
+ return cpu->throttle_us_per_full;
+}
+
+/*
+ * Estimate dirty ring full time under current dirty page rate.
+ * Return -1 if guest doesn't dirty memory.
+ */
+int64_t dirtylimit_us_ring_full(void)
+{
+ uint64_t curr_rate = vcpu_dirty_rate_get(0);
+
+ if (!curr_rate) {
+ return -1;
+ }
+
+ return dirtylimit_dirty_ring_full_time(curr_rate);
+}
+
static struct DirtyLimitInfoList *dirtylimit_query_all(void)
{
int i, index;
--
1.8.3.1
- [PATCH v1 4/8] migration: Implement dirty-limit convergence algo, (continued)
- [PATCH v1 4/8] migration: Implement dirty-limit convergence algo, huangy81, 2022/09/01
- [PATCH v1 1/8] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter, huangy81, 2022/09/01
- [PATCH v1 2/8] qapi/migration: Introduce x-vcpu-dirty-limit parameters, huangy81, 2022/09/01
- [PATCH v1 5/8] migration: Export dirty-limit time info,
huangy81 <=
- [PATCH v1 3/8] migration: Introduce dirty-limit capability, huangy81, 2022/09/01
- [PATCH v1 6/8] tests: Add migration dirty-limit capability test, huangy81, 2022/09/01
- [PATCH v1 7/8] tests/migration: Introduce dirty-ring-size option into guestperf, huangy81, 2022/09/01
- [PATCH v1 8/8] tests/migration: Introduce dirty-limit into guestperf, huangy81, 2022/09/01
- Re: [PATCH v1 0/8] migration: introduce dirtylimit capability, Peter Xu, 2022/09/06