[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 5/6] virtio-net: Update virtio-net curr_queue_pairs in vdpa ba
From: |
Eugenio Pérez |
Subject: |
[PATCH v4 5/6] virtio-net: Update virtio-net curr_queue_pairs in vdpa backends |
Date: |
Tue, 6 Sep 2022 17:07:18 +0200 |
It was returned as error before. Instead of it, simply update the
corresponding field so qemu can send it in the migration data.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>
---
hw/net/virtio-net.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index dd0d056fde..63a8332cd0 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1412,19 +1412,14 @@ static int virtio_net_handle_mq(VirtIONet *n, uint8_t
cmd,
return VIRTIO_NET_ERR;
}
- /* Avoid changing the number of queue_pairs for vdpa device in
- * userspace handler. A future fix is needed to handle the mq
- * change in userspace handler with vhost-vdpa. Let's disable
- * the mq handling from userspace for now and only allow get
- * done through the kernel. Ripples may be seen when falling
- * back to userspace, but without doing it qemu process would
- * crash on a recursive entry to virtio_net_set_status().
- */
+ n->curr_queue_pairs = queue_pairs;
if (nc->peer && nc->peer->info->type == NET_CLIENT_DRIVER_VHOST_VDPA) {
- return VIRTIO_NET_ERR;
+ /*
+ * Avoid updating the backend for a vdpa device: We're only interested
+ * in updating the device model queues.
+ */
+ return VIRTIO_NET_OK;
}
-
- n->curr_queue_pairs = queue_pairs;
/* stop the backend before changing the number of queue_pairs to avoid
handling a
* disabled queue */
virtio_net_set_status(vdev, vdev->status);
--
2.31.1
- [PATCH v4 0/6] Vhost-vdpa Shadow Virtqueue multiqueue support., Eugenio Pérez, 2022/09/06
- [PATCH v4 2/6] vdpa: extract vhost_vdpa_net_load_mac from vhost_vdpa_net_load, Eugenio Pérez, 2022/09/06
- [PATCH v4 1/6] vdpa: Make VhostVDPAState cvq_cmd_in_buffer control ack type, Eugenio Pérez, 2022/09/06
- [PATCH v4 3/6] vdpa: Add vhost_vdpa_net_load_mq, Eugenio Pérez, 2022/09/06
- [PATCH v4 4/6] vdpa: validate MQ CVQ commands, Eugenio Pérez, 2022/09/06
- [PATCH v4 5/6] virtio-net: Update virtio-net curr_queue_pairs in vdpa backends,
Eugenio Pérez <=
- [PATCH v4 6/6] vdpa: Allow MQ feature in SVQ, Eugenio Pérez, 2022/09/06
- Re: [PATCH v4 0/6] Vhost-vdpa Shadow Virtqueue multiqueue support., Jason Wang, 2022/09/08