Re: [PATCH v8 13/14] net: stream: move to QIO

[Markus Armbruster]

Laurent Vivier <lvivier@redhat.com> writes:

> On 9/21/22 16:58, Markus Armbruster wrote:
>> Laurent Vivier <lvivier@redhat.com> writes:
>> 
>>> Use QIOChannel, QIOChannelSocket and QIONetListener.
>>>
>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>> ---
>> [...]
>> 
>>> diff --git a/qemu-options.hx b/qemu-options.hx
>>> index ee2436ae14a7..a0b5b70c80cb 100644
>>> --- a/qemu-options.hx
>>> +++ b/qemu-options.hx
>>> @@ -2732,8 +2732,8 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev,
>>>       "-netdev socket,id=str[,fd=h][,udp=host:port][,localaddr=host:port]\n"
>>>       "                configure a network backend to connect to another 
>>> network\n"
>>>       "                using an UDP tunnel\n"
>>> -    "-netdev 
>>> stream,id=str[,server=on|off],addr.type=inet,addr.host=host,addr.port=port\n"
>>> -    "-netdev stream,id=str[,server=on|off],addr.type=unix,addr.path=path\n"
>>> +    "-netdev 
>>> stream,id=str[,server=on|off],addr.type=inet,addr.host=host,addr.port=port[,to=maxport][,numeric=on|off][,keep-alive=on|off][,mptcp=on|off][,addr.ipv4=on|off][,addr.ipv6=on|off]\n"
>>> +    "-netdev 
>>> stream,id=str[,server=on|off],addr.type=unix,addr.path=path[,abstract=on|off][,tight=on|off]\n"
>>>       "-netdev stream,id=str[,server=on|off],addr.type=fd,addr.str=h\n"
>>>       "                configure a network backend to connect to another 
>>> network\n"
>>>       "                using a socket connection in stream mode.\n"
>> The commit message didn't prepare me for this change.  Could you
>> explain?
>> 
>
> You're right, I should explain:
>
> moving to QIOChannel allows net/stream to use the all the available 
> parameters provided by SocketAddress. They were not listed here before 
> because they were not supported, and as 
> they are supported now I have added them in the list.

Fine addition to the commit message.  Suggest to amend its subject like

    net stream: move to QIO to enable additional parameters

or

    net stream: move to QIO, enabling additional parameters