[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] migration: Disallow xbzrle with postcopy
From: |
Peter Xu |
Subject: |
Re: [PATCH 3/5] migration: Disallow xbzrle with postcopy |
Date: |
Thu, 22 Sep 2022 15:28:28 -0400 |
On Thu, Sep 22, 2022 at 04:56:21PM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (peterx@redhat.com) wrote:
> > It's not supported since the 1st day, as ram_load_postcopy does not handle
> > RAM_SAVE_FLAG_XBZRLE. Mark it disabled explicitly.
>
> We've already got a check in ram_save_page:
>
> if (rs->xbzrle_enabled && !migration_in_postcopy()) {
> pages = save_xbzrle_page(rs, &p, current_addr, block,
> offset);
>
> so that's supposed to allow you to enable xbzrle with postcopy and take
> advantage of xbzrle during the precopy phase.
Ah! Makes sense. I'll drop this one.
--
Peter Xu
[PATCH 1/5] migration: Fix possible deadloop of ram save process, Peter Xu, 2022/09/20