Re: [PATCH v11 04/15] target/hexagon: make helper functions non-static

[Philippe Mathieu-Daudé]

On 4/8/22 13:55, Anton Johansson via wrote:
> From: Paolo Montesel <babush@rev.ng>
>
> Make certain helper functions non-static, making them available outside
> genptr.c. These functions are required by code generated by the
> idef-parser.
>
> This commit also makes some functions in op_helper.c non-static in order
> to avoid having them marked as unused when using the idef-parser
> generated code.
>
> Signed-off-by: Alessandro Di Federico <ale@rev.ng>
> Signed-off-by: Paolo Montesel <babush@rev.ng>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
>   target/hexagon/genptr.c    | 61 +++++++++++++++++++++-----------------
>   target/hexagon/genptr.h    | 31 +++++++++++++++++++
>   target/hexagon/op_helper.c | 29 ++++++++----------
>   target/hexagon/op_helper.h | 37 +++++++++++++++++++++++
>   4 files changed, 115 insertions(+), 43 deletions(-)
>   create mode 100644 target/hexagon/op_helper.h

> diff --git a/target/hexagon/op_helper.h b/target/hexagon/op_helper.h
> new file mode 100644
> index 0000000000..9fbebf11c3
> --- /dev/null
> +++ b/target/hexagon/op_helper.h
> @@ -0,0 +1,37 @@
> +/*
> + *  Copyright(c) 2019-2021 Qualcomm Innovation Center, Inc. All Rights 
> Reserved.
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
> + *
> + *  This program is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef HEXAGON_OP_HELPER_H
> +#define HEXAGON_OP_HELPER_H
> +
> +/* Misc functions */
> +void cancel_slot(CPUHexagonState *env, uint32_t slot);

'unsigned slot'

> +void write_new_pc(CPUHexagonState *env, target_ulong addr);
> +
> +uint8_t mem_load1(CPUHexagonState *env, uint32_t slot, target_ulong vaddr);
> +uint16_t mem_load2(CPUHexagonState *env, uint32_t slot, target_ulong vaddr);
> +uint32_t mem_load4(CPUHexagonState *env, uint32_t slot, target_ulong vaddr);
> +uint64_t mem_load8(CPUHexagonState *env, uint32_t slot, target_ulong vaddr);

Ditto.

> +void log_reg_write(CPUHexagonState *env, int rnum,
> +                   target_ulong val, uint32_t slot);

Ditto.

> +void log_store64(CPUHexagonState *env, target_ulong addr,
> +                 int64_t val, int width, int slot);
'unsigned' :)

> +void log_store32(CPUHexagonState *env, target_ulong addr,
> +                 target_ulong val, int width, int slot);

Ditto.