qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/2] target/loongarch: Adjust the layout of hardware flags


From: Richard Henderson
Subject: Re: [PATCH v3 1/2] target/loongarch: Adjust the layout of hardware flags bit fields
Date: Sat, 5 Nov 2022 09:08:17 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 11/4/22 15:05, Rui Wang wrote:
  static bool check_plv(DisasContext *ctx)
  {
-    if (ctx->base.tb->flags == MMU_USER_IDX) {
+    if (ctx->mem_idx == MMU_USER_IDX) {

Not quite. This needs to check HW_FLAGS_PLV_MASK, not the mem_idx. That was the intent of keeping them separate in HW_FLAGS.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]