|
| From: | Richard Henderson |
| Subject: | Re: [PATCH v3 07/11] Hexagon (target/hexagon) Add overrides for direct call instructions |
| Date: | Sat, 5 Nov 2022 11:19:18 +1100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 |
On 11/5/22 06:26, Taylor Simpson wrote:
+ tcg_gen_andi_tl(lsb, pred, 1);
+ if (!sense) {
+ tcg_gen_xori_tl(lsb, lsb, 1);
+ }
+ gen_write_new_pc_pcrel(ctx, pc_off, lsb);
+ tcg_gen_brcondi_tl(TCG_COND_EQ, lsb, 0, skip);
Better to change the branch condition than invert the lsb. r~
| [Prev in Thread] | Current Thread | [Next in Thread] |