Re: [PATCH v3 09/11] Hexagon (target/hexagon) Add overrides for various forms of jump

[Richard Henderson]

On 11/5/22 06:26, Taylor Simpson wrote:
> +static void gen_cmp_jumpnv(DisasContext *ctx,
> +                           TCGCond cond, TCGv val, TCGv src, int pc_off)
> +{
> +    TCGv pred = tcg_temp_new();
> +    tcg_gen_setcond_tl(cond, pred, val, src);
> +    gen_cond_jump(ctx, pred, pc_off);

This, in particular could benefit from the complete branch condition being passed down, 
rather than setcond here then brcond based on the result.

But it's still an improvement, so,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~