[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/8] tulip: Remove unused variable
|
From: |
Thomas Huth |
|
Subject: |
[PULL 2/8] tulip: Remove unused variable |
|
Date: |
Fri, 11 Nov 2022 11:30:42 +0100 |
From: Miroslav Rezanina <mrezanin@redhat.com>
Variable n used in tulip_idblock_crc function is only incremented but never
read.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.
Removing the variable to prevent the warning.
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id:
<02e1560d115c208df32236df8916fed98429fda1.1668009030.git.mrezanin@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/net/tulip.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/net/tulip.c b/hw/net/tulip.c
index b9e42c322a..c2b3b1bdfa 100644
--- a/hw/net/tulip.c
+++ b/hw/net/tulip.c
@@ -870,11 +870,10 @@ static const MemoryRegionOps tulip_ops = {
static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
{
- int word, n;
+ int word;
int bit;
unsigned char bitval, crc;
const int len = 9;
- n = 0;
crc = -1;
for (word = 0; word < len; word++) {
@@ -887,7 +886,6 @@ static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
srom[len - 1] = (srom[len - 1] & 0xff00) | (unsigned short)crc;
break;
}
- n++;
bitval = ((srom[word] >> bit) & 1) ^ ((crc >> 7) & 1);
crc = crc << 1;
if (bitval == 1) {
--
2.31.1
- [PULL 0/8] Misc fixes, Thomas Huth, 2022/11/11
- [PULL 1/8] rtl8139: Remove unused variable, Thomas Huth, 2022/11/11
- [PULL 2/8] tulip: Remove unused variable,
Thomas Huth <=
- [PULL 3/8] qemu-img: remove unused variable, Thomas Huth, 2022/11/11
- [PULL 4/8] host-libusb: Remove unused variable, Thomas Huth, 2022/11/11
- [PULL 5/8] libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15, Thomas Huth, 2022/11/11
- [PULL 7/8] net: Replace TAB indentations with spaces, Thomas Huth, 2022/11/11
- [PULL 8/8] Fix several typos in documentation (found by codespell), Thomas Huth, 2022/11/11
- [PULL 6/8] qga: Allow building of the guest agent without system emulators or tools, Thomas Huth, 2022/11/11
- Re: [PULL 0/8] Misc fixes, Stefan Hajnoczi, 2022/11/12