[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/8] host-libusb: Remove unused variable
|
From: |
Thomas Huth |
|
Subject: |
[PULL 4/8] host-libusb: Remove unused variable |
|
Date: |
Fri, 11 Nov 2022 11:30:44 +0100 |
From: Miroslav Rezanina <mrezanin@redhat.com>
Variable unconnected used in usb_host_auto_check function is only incremented
but never read as line where it is read was disabled since introducing the code.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.
Removing the variable and disabled code to prevent the warning.
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id:
<00df0db69ff9167d38bac81f6d03281955bd861a.1668009030.git.mrezanin@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/usb/host-libusb.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index 28f8af8941..176868d345 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@ -1837,7 +1837,6 @@ static void usb_host_auto_check(void *unused)
struct USBAutoFilter *f;
libusb_device **devs = NULL;
struct libusb_device_descriptor ddesc;
- int unconnected = 0;
int i, n;
if (usb_host_init() != 0) {
@@ -1897,9 +1896,6 @@ static void usb_host_auto_check(void *unused)
libusb_free_device_list(devs, 1);
QTAILQ_FOREACH(s, &hostdevs, next) {
- if (s->dh == NULL) {
- unconnected++;
- }
if (s->seen == 0) {
if (s->dh) {
usb_host_close(s);
@@ -1908,17 +1904,6 @@ static void usb_host_auto_check(void *unused)
}
s->seen = 0;
}
-
-#if 0
- if (unconnected == 0) {
- /* nothing to watch */
- if (usb_auto_timer) {
- timer_del(usb_auto_timer);
- trace_usb_host_auto_scan_disabled();
- }
- return;
- }
-#endif
}
if (!usb_vmstate) {
--
2.31.1
- [PULL 0/8] Misc fixes, Thomas Huth, 2022/11/11
- [PULL 1/8] rtl8139: Remove unused variable, Thomas Huth, 2022/11/11
- [PULL 2/8] tulip: Remove unused variable, Thomas Huth, 2022/11/11
- [PULL 3/8] qemu-img: remove unused variable, Thomas Huth, 2022/11/11
- [PULL 4/8] host-libusb: Remove unused variable,
Thomas Huth <=
- [PULL 5/8] libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15, Thomas Huth, 2022/11/11
- [PULL 7/8] net: Replace TAB indentations with spaces, Thomas Huth, 2022/11/11
- [PULL 8/8] Fix several typos in documentation (found by codespell), Thomas Huth, 2022/11/11
- [PULL 6/8] qga: Allow building of the guest agent without system emulators or tools, Thomas Huth, 2022/11/11
- Re: [PULL 0/8] Misc fixes, Stefan Hajnoczi, 2022/11/12