[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/5] migration: Use non-atomic ops for clear log bitmap
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v2 4/5] migration: Use non-atomic ops for clear log bitmap |
|
Date: |
Mon, 14 Nov 2022 15:04:05 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) |
Peter Xu <peterx@redhat.com> wrote:
> Since we already have bitmap_mutex to protect either the dirty bitmap or
> the clear log bitmap, we don't need atomic operations to set/clear/test on
> the clear log bitmap. Switching all ops from atomic to non-atomic
> versions, meanwhile touch up the comments to show which lock is in charge.
>
> Introduced non-atomic version of bitmap_test_and_clear_atomic(), mostly the
> same as the atomic version but simplified a few places, e.g. dropped the
> "old_bits" variable, and also the explicit memory barriers.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 4/5] migration: Use non-atomic ops for clear log bitmap,
Juan Quintela <=