[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/8] tests/avocado: configure acpi-bits to use avocado timeout
|
From: |
Michael S. Tsirkin |
|
Subject: |
[PULL 6/8] tests/avocado: configure acpi-bits to use avocado timeout |
|
Date: |
Tue, 22 Nov 2022 05:23:39 -0500 |
From: John Snow <jsnow@redhat.com>
Instead of using a hardcoded timeout, just rely on Avocado's built-in
test case timeout. This helps avoid timeout issues on machines where 60
seconds is not sufficient.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20221115212759.3095751-1-jsnow@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Ani Sinha <ani@anisinha.ca>
---
tests/avocado/acpi-bits.py | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/tests/avocado/acpi-bits.py b/tests/avocado/acpi-bits.py
index 8745a58a76..ac13e22dc9 100644
--- a/tests/avocado/acpi-bits.py
+++ b/tests/avocado/acpi-bits.py
@@ -385,12 +385,6 @@ def test_acpi_smbios_bits(self):
self._vm.launch()
# biosbits has been configured to run all the specified test suites
# in batch mode and then automatically initiate a vm shutdown.
- # sleep for maximum of one minute
- max_sleep_time = time.monotonic() + 60
- while self._vm.is_running() and time.monotonic() < max_sleep_time:
- time.sleep(1)
-
- self.assertFalse(time.monotonic() > max_sleep_time,
- 'The VM seems to have failed to shutdown in time')
-
+ # Rely on avocado's unit test timeout.
+ self._vm.wait(timeout=None)
self.parse_log()
--
MST
- [PULL 0/8] pc,virtio: regression, test fixes, Michael S. Tsirkin, 2022/11/22
- [PULL 1/8] vhost: mask VIRTIO_F_RING_RESET for vhost and vhost-user devices, Michael S. Tsirkin, 2022/11/22
- [PULL 2/8] tests: acpi: whitelist DSDT before moving PRQx to _SB scope, Michael S. Tsirkin, 2022/11/22
- [PULL 3/8] acpi: x86: move RPQx field back to _SB scope, Michael S. Tsirkin, 2022/11/22
- [PULL 4/8] tests: acpi: x86: update expected DSDT after moving PRQx fields in _SB scope, Michael S. Tsirkin, 2022/11/22
- [PULL 5/8] MAINTAINERS: add mst to list of biosbits maintainers, Michael S. Tsirkin, 2022/11/22
- [PULL 6/8] tests/avocado: configure acpi-bits to use avocado timeout,
Michael S. Tsirkin <=
- [PULL 7/8] acpi/tests/avocado/bits: keep the work directory when BITS_DEBUG is set in env, Michael S. Tsirkin, 2022/11/22
- [PULL 8/8] virtio: disable error for out of spec queue-enable, Michael S. Tsirkin, 2022/11/22
- Re: [PULL 0/8] pc,virtio: regression, test fixes, Stefan Hajnoczi, 2022/11/22